MAF CLOUD - NEW RELEASE + FIX UPDATES JUN 2023

kgi bond price format issue

bond price is very special in futures market.

for kgi CBOT/21, if the price is 112.2050, but after converting, it is 112.640625

Enhancement

-

https://mafint.atlassian.net/browse/MAF-3960

add Bal Qty in STOCK DETAILS table

1. this column will be empty in select API

2. add a new button to calculate bal qty

3. after click the button, BE return bal_qty based on each link_phy_trade_id

4. fill up the column in the table

API logic:

1. FE preload data to BE is all the link_phy_trade_ids

2. bal_qty = contract_stock_qty of phy_trade_id (=link_phy_trade_id) + sum all contract_stock_qty based on link_phy_trade_id

   1. BE only check 1 and 2 stock actions (stock in or stock out), the other types of stock action qty will be treated as 0 will apply for all stock type (stock in/out, relocate in/out and swap in/out)

   2. 1 is positive and 2 is negative of contract_stock_qty

Bal Qty will not be save, just click Calculate button will calculate all.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3935

add Bal Qty in STOCK DETAILS table

1. this column will be empty in select API

2. add a new button to calculate bal qty

3. after click the button, BE return bal_qty based on each link_phy_trade_id

4. fill up the column in the table

API logic:

1. FE preload data to BE is all the link_phy_trade_ids

2. bal_qty = contract_stock_qty of phy_trade_id (=link_phy_trade_id) + sum all contract_stock_qty based on link_phy_trade_id

   1. BE only check 1 and 2 stock actions (stock in or stock out), the other types of stock action qty will be treated as 0 will apply for all stock type (stock in/out, relocate in/out and swap in/out)

   2. 1 is positive and 2 is negative of contract_stock_qty

Bal Qty will not be save, just click Calculate button will calculate all.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3935

add Bal Qty in STOCK DETAILS table

1. this column will be empty in select API

2. add a new button to calculate bal qty

3. after click the button, BE return bal_qty based on each link_phy_trade_id

4. fill up the column in the table

API logic:

1. FE preload data to BE is all the link_phy_trade_ids

2. bal_qty = contract_stock_qty of phy_trade_id (=link_phy_trade_id) + sum all contract_stock_qty based on link_phy_trade_id

   1. BE only check 1 and 2 stock actions (stock in or stock out), the other types of stock action qty will be treated as 0 will apply for all stock type (stock in/out, relocate in/out and swap in/out)

   2. 1 is positive and 2 is negative of contract_stock_qty
      
      

Bal Qty will not be save, just click Calculate button will calculate all.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3935

1. 合同数量容易歧义，改成理论出入库数量；change contract qty column chinese name in stock mgmt

2. 数量改成实际出入库数量（理论出入库数量与实际出入库数量都优先带入合同未出入库数量，允许修改）change qty column chinese name in stock mgmt

3. in stock mgmt, add new row, once select contract no, both contract qty and qty columns should auto fill with unstock qty

4. both contract qty and qty columns allow edit

5. contract no drop down list in stock mgmt need to update accordingly

logic is if stock qty (contract qty in stock mgmt) is not input yet, stock qty = 0 so unstock qty in new phy = qty in new phy (contract qty in new phy)

stock in/out in stock mgmt and new phy trade table stock qty and unstock qty will be updated

unstock qty = contract actual qty/qty in new phy trade - stock qty in new phy trade [stock in/out contract qty in stock mgmt table]

No need real time update for unstock qty.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3953

add new key and column for paper trade

background: 

Hai Tian wanna do access control for paper trade.

1. their user will key view_group_id (maf_group_id) for each trade

2. in BE will hard code for Hai Tian company to select trade based on view_group_id (maf_group_id)

3. only for hai tian company at this moment.

Database is updated and pushed.

FE trade table

1. trade table

   1. key: view_group_id

   2. column: GROUP ID

   3. dropdown list: all the groups under user's company (value is maf_group_id, label is maf_group_name)

   4. validation: true

   5. editable

2. outside the table

   1. same as portfolio, user is able to select trades, and select GROUP to update all select trades GROUP ID

3. view, update and insert should work for GROUP ID

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3955

only stock in can insert/edit link_phy_id in stock mgmt table

only stock in can insert/edit link_phy_id (link contract no column) in stock mgmt table

if stock action is empty, link_phy_id cannot be editable

does not apply for pair details table

->stock action is stock in, stock out, move in, move out, swap in and swap out with link contract no

only allow stock in has link contract no.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3957

created by and date in paper trade are invalid

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3958

sale contract in link contract no should be negative

sale contract should be negative in link contract no in stock mgmt, i click on link contract number and all the sale contract shows positive qty but they should be negative

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3959

filter away contract no if unstock qty is 0 in BOTH CONTRACT NO and LINK CONTRACT NO in stock mgmt (unstock qty 0 should not appear in contract no drop down list) same as ps ledger

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3961

cannot use stock mgmt if choose later start date

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3952

for both new apps Unpriced Contract Schedule and Purchase Sale Summary, when click on the open in new window button, will be empty

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3954

demurrage cannot download attachment due to characters input by simplied chinese keyboard

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3956

translate in new phy trade - physical and warrant

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3951

采/销售量汇总

Users need to choose summary mode first: CONTRACT or STOCK 业务口径或者财务口径

Aggregate all contracts based on P/S DATE, PRODUCT, PURCHASE/SALE, TRADE MODE, and calculate the sum of QTY, AMT, AMT BEFORE TAX

columns:

P/S DATE 采/销日期：based on the time dimensions (note a) and summary mode (note b)

PRODUCT 品种

PURCHASE/SALE 采/销

TRADE MODE 交易模式

QTY 数量： based on summary mode (note b)

AMT 采/销成本： QTY * PRICE （priority：CONTRACT ACTUAL PRICE > PROVISIONAL PRICE)

AMT BEFORE TAX 采/销不含税成本： AMT/ （1+ CONTRACT TAX RATE）

note a:

Three time dimensions: daily, weekly, monthly

Daily：specific date

weekly: 某月第几周

monthly：几月

note b:

Two summary modes based on CONTRACT or STOCK

CONTRACT 业务口径：P/S DATE is based on trade date in new physical trade table, QTY is (priority: CONTRACT ACTUAL QTY > QTY in physical trade)

STOCK 财务口径：P/S DATE is based on stock date in stock management, QTY is stock_contract_qty

P/S DATE 采/销日期：based on the time dimensions (note a) and summary mode (note b)

PRODUCT 品种

PURCHASE/SALE 采/销

TRADE MODE 交易模式

QTY 数量： based on summary mode (note b)

AMT 采/销成本： QTY * PRICE （priority：CONTRACT ACTUAL PRICE > PROVISIONAL PRICE)

AMT BEFORE TAX 采/销不含税成本： AMT/ （1+ CONTRACT TAX RATE）

1. Date dimension handle by BE

2. group by PRODUCT 品种, PURCHASE/SALE 采/销, TRADE MODE 交易模式 handle by FE table

3. AMT 采/销成本： QTY * PRICE （priority：CONTRACT ACTUAL PRICE > PROVISIONAL PRICE)

   AMT BEFORE TAX 采/销不含税成本： AMT/ （1+ CONTRACT TAX RATE） → should be same as phy trade table formula.

make it more flexible, we put group keys in settings and let users to choose. the dropdown list could from BE dashboard meta data

PRODUCT 品种

PURCHASE/SALE 采/销

TRADE MODE 交易模式

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3946

Add new columns in STOCK MANAGEMENT

some changes in the table:

1. remove TO WH NAME

2. stock action will use stock action in dropdown list

3. stock_type will use stock type in dropdown list

4. if stock_action value is [1, 3, 5], qty show positive in table, if stock_action value is in [2,4,6], qty show negative in table. but when pass it to BE, it is always positive of value

5. Does Scope column needs to be removed? Because currently BE did not return this param anymore

YES, no more Scope

Match ID no longer using dropdown list right, if so does the previous logic remained the same or need to do some changes? 

No more logic for Match ID and also remove Bal Qty in FE.

Stock Action:

• Stock Out 出库

• Stock In 入库

• Swap In 仓转现

• Swap Out 现转仓

• Relocate In 移进库

• Relocate Out 移出库

Stock Type

• Physical 现货

• Warrant 仓单

Note: DELIVERY MODE will changes to non-editable, auto fill when there are delivery rule value returned from CONTRACT NO. dropdown （provisionally）

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3907

Update in STOCK MANAGEMENT

1: Add more information in CONTRACT NO. dropdown list

• BRAND

• QTY (priority: CONTRACT ACTUAL QTY > QTY)

• UNSTOCK QTY

2: Add BRAND column (from phy trade)

before SPEC

auto fill by Contract No

3: FE auto fill WH NAME with CONTRACT WH (phy trade)

• editable

4: FE auto fill BRAND and SPEC once CONTRACT NO. is chosen

• These two columns are editable

• If BRAND/SPEC is different from what in new physical trade table , highlight them green

1. in stock_mgmt DB, i have added two more keys called stock_brand and stock_spec

2. when user choose contract no which have brand and spec from phy trade table, if Brand and Spec in stock mgmt table columns are empty, please auto fill up. otherwise, please keep original value

3. if stock_brand and stock_spec value are different from contract brand and spec, highligh them in green

4. when save (update or insert), please store value in stock_mgmt Database → stock_brand and stock_spec

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3908

free trial user can create 20 groups now

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3929

Reallocation function in stock management page

there is an action called REALLOCATION. It means move cargo from one warehouse to another warehouse. So we will add a new button called REALLOCATION to function it easily

1. user is able to multi select rows with positive qty (which means stock_action is in 1, 3, 5)

2. then click REALLOCATION button (use icon for button, hint ALLOCATION when move mouse over the icon)

3. pop up a new window for user to reallocate

4. click SAVE to call reallocate_api

1. TO WH NAME: dropdown list

2. QTY: must be positive number

API:

1. BE will insert two rows in DB for each row

   1. 1st row: copy original selected row,

      1. remove stock_id

      2. stock_action: move out

      3. stock_qty: qty

      4. match_id: original stock_id

   2. 2nd row: copy original selected row:

      1. remove stock_id

      2. stock_action: move in

      3. wh_id: TO WH NAME

      4. stock_qty: qty

      5. match_id: original stock_id

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3930

stock management table update

1. disable match_Id edit, view only

2. delivery mode editable

   1. dropdown list

   2. from phy_trade side

   3. when update, BE should update phy_trade based on phy_trade_id

https://mafint.atlassian.net/browse/MAF-3932

Modify WAREHOUSE column in TRADES tab

1. WAREHOUSE in new phy trades table should be no editable From WH NAME in STOCK MANAGEMENT

2. change WH ADDESS to CONTRACT WH ADD

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3933

STOCK MANAGEMENT swap

swap function is similar to reallocate function.

reallocate function is to insert two row with different wh_id

swap function is to insert two row with different stock_type

so in swap window:

1. user choose stock_type and qty

2. stock_type should be different from original (selected) row. (validation in FE)

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3934

stock mgmt table issue fixed

1. stock mgmt will be empty wh entity empty when select contract no, but when save it will auto appear - please add wh entity in the dropdown list.

once you update cargo ops data, all the rows with same Contract No will change together.

means delivery mode, bl no, loadport, lp etd, disport, dp eta, cc date, do date, will follow previous contract no and update accordingly

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3937

change wh_id to stock_wh_id in stock mgmt table

1. to different wh_id from physical trade and stock mgmt table, now we change wh_id to stock_wh_id in stock mgmt table

2. in stock mgmt table, if WH NAME is empty, when user select contract no, FE will auto fill it based on wh_id in physical trade

   1. if WH NAME has value, it wont be update based on selected contract no.

3. but user is able to edit WH NAME in the stock mgmt table. because it is actual wh name and the value will be stored in stock mgmt able stock_wh_id

4. highlight in green if stock_wh_id different from wh_id in contract no dropdown list.

if wh name different in stock mgmt and new phy trade, it will show in green

same for brand and spec

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3938

add two keys in stock mgmt

1. link_phy_trade_id:

   1. 匹配合同号

   2. LINK CONTRACT NO.

   3. dropdown down list from phy_trade_id

   4. only filter out sale trade in dropdown list

2. stock_contract_qty:

   1. 合约数量

   2. CONTRACT QTY

   3. float

   4. sign of number is same as qty in table

   5. to BE must be positive

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3940

new physical trade table - contract wh address empty - when change contract wh in new physical trade table, contract wh add is empty bug fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3941

New app in dashboard - Unpriced Contract Schedule

For contracts whose CONTRACT ACTUAL PEICE and PRICING PRICE are both blank

data from physical trade：

公司名称 ENTITY OF CONTRACT

产品 PRODUCT

客户 COUNTERPARTY

合同号 CONTRACT NO.

升贴水 CONTRACT PREMIUM

作价方 PRICING PARTY

约定点价日期 PRICING DATE

约定点价合约 PRICING CONTRACT

New

未点价数量 UNPRICE QTY

UNPRICE QTY = (priority: CONTRACT ACTUAL QTY > QTY)

Preload is s_date and e_date, as the setting only consist Start Date and End Date

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3942

stock mgmt table empty fields bug fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3943

unstock qty currently we are using stock_qty to calculate.

now we change to stock_contract_qty to calculate

contract qty (stock_contract_qty) in stock mgmt table should reflect in stock qty in new phy trade table

in new phy trade table : unstock qty = qty - stock qty

1. link_phy_trade_id:

   1. 匹配合同号

   2. LINK CONTRACT NO.

   3. dropdown down list from phy_trade_id

   4. only filter out sale trade in dropdown list

2. stock_contract_qty:

   1. 合约数量

   2. CONTRACT QTY

   3. float

   4. sign of number is same as qty in table

   5. to BE must be positive

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3944

stock mgmt filter in table bug fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3945

stock mgmt table layout bug fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3947

Company level account has no permission to access settings

If the account is company level and not in the group, it has no permission to access settings in GROUP MANAGEMENT

ex: test2 is company level, but can’t enter the access settings in Group D - 能化部 - 塑料

Now the logic is only ADMIN in the group can enter Access settings.

The new logic: Both ADMIN of the group and the Group Owner can change the access settings

please remove Access Settings filter in FE. BE already handle the validation check. it is priority task and we need to push today. once it is done, please move to in process, so kelin can assist in checking.

hi Kelin, view, insert and delete all has validation check in BE. only group admin and group owner can view, insert and delete (tick and untick)

https://mafint.atlassian.net/browse/MAF-3921

link warehouse columns in company data and trades table

HT‘s 2 issues below are the same thing

1. change warehouse 仓储 label to 约定仓储名称 Contract WH in trades table

2. link WH Name in company data table to the Warehouse column in trades table

for reference:

current in trades table: Warehouse 仓储

current in company data table: WH Entity 仓储公司 and WH Name 仓储名称

1. I have add new column in db called wh_id (Integer) to store Contract WH

   1. current Warehouse (wh) column we keep first.

   2. once we done this ticket, we will ask user to copy past wh data into wh_id and save

   3. once saved, then we will issue a new ticket to remove wh permanently.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3903

Add new columns in Phy TRADES tab for stock management

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3905

Add WH ADRESS in COMPANY DATA -> WAREHOUSES

WH ADDRESS: key is wh_add

please add the column in the table.

just simple text format, not must item.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3906

WH ISSUE IN PHY TRADE TABLE

Now in phy trades table, it could show WH NAME & STATUS and STOCK QTY correctly

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3910

change dashboard apps share accounts range

dashboard apps are supposed to share with all company level accounts + all parent group level accounts

Now only Company level accounts

1. change USER view to COMPANY LEVEL

2. change FEATURE CHART update to COMPANY level

3. change FEATURE CHART view to COMPANY level for all received shared apps users

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3928

Translate error for stock action

stock in 入库

stock out 出库

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185 =

https://mafint.atlassian.net/browse/MAF-3931

Issue for loading apps in dashboard fixed

Now dashboard limit to 2 apps one time to call, only load another 2 app after current finished

However, if the first 2 always keep loading, they can’t even scroll down to see other apps.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/197951606

https://mafint.atlassian.net/browse/MAF-3902

Filter setting enhancement for group dashboard and share link

Make filter setting of apps in group dashboard and share link same as those in Sharer‘s account dashboard

refers to saving of filtered rows in table layout

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/197951606

https://mafint.atlassian.net/browse/MAF-3915

group access permission bug fixed

1. view logic:

   1. select all assigned psl row based on contract no under group level

   2. select all unassigned psl row based on company level

2. update logic

   1. update must be company level (admin to set)

Enhancement

-

https://mafint.atlassian.net/browse/MAF-3916

https://mafint.atlassian.net/browse/MAF-3919

https://mafint.atlassian.net/browse/MAF-3922

update and delete in PSL access permission fixed

Enhancement

-

https://mafint.atlassian.net/browse/MAF-3918

dashboard - share link for dashboard models got error

test2 dashboard

position matrix

Counterparty Position Risk Summary

Portfolio Total P/L by Instrument Contract

Portfolio Grid

share link got this error

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/197951606

https://mafint.atlassian.net/browse/MAF-3923

dashboard

• daily pricing position change bug fixed

• portfolio return green highlight for light theme fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/197951606

https://mafint.atlassian.net/browse/MAF-3924

https://mafint.atlassian.net/browse/MAF-3925

1. view logic:

   1. select all assigned psl row based on contract no under group level

   2. select all unassigned psl row based on company level

2. update logic

   1. update must be company level (admin to set)

for reference after fix:

• current logic for psl and invoice unassigned/assigned function

• for company level, can see all groups data in unassigned and assigned table

for group level, can see all groups' data in unassigned table, but for assigned table, only can see own group data - whoever create the contract no will see the contract in their own group after assigned - will use this to determine what user see in assigned table, instead of created/updated

what each user in own group can view/edit/delete will be determined by group access permission (api level) - to be controlled (ticked in page) by group owner/group admin

• if company level, can view/edit/delete own and other groups' data

• if group level, can only view/edit/delete own group member and self data

Enhancement

https://mafint.atlassian.net/browse/MAF-3927

1. INVOICE pre setting data missing in ISSUE tab

Haitian stated that Invoice pre setting company data missing in ISSUE tab
The dropdown list of ITEMS is blank

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3909

2. Bug for bank information missing in PSL - Partial bank information(company level data) missing in PSL

group level issue. group level can not get bank details (bank details user id is not in the same group)

now it is default in company level to get company data.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3913

1. Make columns no editable in PSL & Invoice

update restriction (it means those rows have psl_id)

In PSL, RECEIVE and ISSUE, both assigned and unassigned (only tables, not include allocate window), set all columns no editable except CONTRACT NO.

for insert new one, still allow user to edit before saving.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3894

2. Add delete button in access permission table. so we can tick the row and delete

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3895

3. group - after changing parent company details not updated and translate parent group

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/532939846

https://mafint.atlassian.net/browse/MAF-3897

https://mafint.atlassian.net/browse/MAF-3898

4. in ps ledger, remove psl type column since ps ledger is meant for recording payment transactions but payment value still need return to BE

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3899

5. ps ledger - assigned/unassigned/issued/unissued drop down list

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3896

1. ps ledger and receive (psl in access setting for assigned/unassigned dropdown list)

• unassigned is company level, anyone can view/edit/delete

• assigned is group level, only member in same group can view/edit/ delete. Company level can view/edit/delete group level data as well

issue (psl in access setting for issued/unissued dropdown list)

• unissued is company level as no contract no yet so cannot determine which items belong to who yet (doesnt use created by to determine)

• issued is group level, only member in same group can view/edit/ delete. Company level can view/edit/delete group level data as well; due to group level, user cannot delete other user’s invoice items in unissued/issued table

采销资金/收票:                                                                      

未分配：公司级，所有group都能看到，各个group下的人只能合并，分批或是直接认领合同号，不能修改和删除任何数据，也不能用添加行新增数据                                                                                       

已分配：group级别，同一group的人能看到，其他group不能看到，只能修改合同号或是取消合同号使其回到未分配里，其他数据不能修改或删除 

开票:  

未开票/已开票：group级别，同一group的人能看到，其他group的人不能看到                     

以上所有数据公司级别的人都能看到       （添加行和删除权限是否可以放给指定的账号？目前创建人可以删除存在BUG,当分批以后，创建人就变成了商务执行人员）

Solution

1. Set Dg group as company level

2. set other operation team as group level    

3. for those 未分配 psl, will select by company level no matter the user is under group level or company level.

Testing:

1. two groups under one company.

2. one group under company level for psl API (you can set access level in admin page)

3. one group under group level for psl API

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3869

2. VIEW operation missing in Accession Permission tab of PSL

for PSL， there are only DELETE and CREATE, type VIEW missing

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3882

3. phy trade diag check

currently, it may have some portfolio pl calculation issue from phy trades. It is caused by many many reasons, so we provide a page for user to do self check.

1. add a tab in the last in page new phy trade, called DAIG CHECK

2. go to the tab, call select API to get response for diag type list for user to choose to check

3. select one diag type click check to call API get error trades in the table below. if rsp is empty, it means no error

4. 'DUPLICATED PRICING IDS',

   1. to check if any duplicated pricing id in linked paper trades

5. 'TRADE AND PRICING QTY DISCREPANCIES'

   1. to check if qty in linked paper trades and qty (actual qty or qty) in pricing are discrepant

in duplicated pricing ids:

it is only to test if any duplicated pricing ids in the trades (linked to physical trade). so we only focus on Phy Pricing IDs column. please ignore other columns for this diag type.

We will have more diag types to check in the future.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3873

4. add Accession Permission tab table in Admin page

1. only admin is able to view (FE control)

2. only admin is able to edit (BE control)

3. only access_level is able to edit

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3865

5. Issue - item and tax rate are empty after saving bug fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3884

6. master group (has children groups) is able to access children groups data

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3885

7. Cannot generate demurrage report bug fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/450233511

https://mafint.atlassian.net/browse/MAF-3887

8. Cannot delete item in trade table bug fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3888

9. Currently we have performance issue in dashboard.

so let’s limit No. of apps loading once a time

1. limit to 2 apps one time to call, only load another 2 app after current finished

2. personal dashboard and group dashboard both

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/1962803314

https://mafint.atlassian.net/browse/MAF-3717

10. maf group hierarchy

currently, MAF group only have two types:

1. group level

2. company level

Now in group level, we add hierarchy tree structure to maf group level. it is similar to portfolio structure.

once it is done, then one group could be parent of other groups.

ATM, we only support two levels groups

1. company level

2. master group

3. group

test case

1. create group

   1. if there is parent group,

      1. BE will check if parent group has the same owner of creator

2. delete group:

   1. if deleted group has children groups

      1. if deleted group does not have parent group, then all children groups parent group will empty

      2. else all children groups parent group will update to the deleted group parent group

3. update group

   1. if change owner of group, will raise error if

      1. updated group has parent or

      2. updated group has children groups

   2. validate infinity parent loop

      1. if parent group is the same as updated group, will raise error

      2. if cross parent group, will raise error

         1. e.g., A is B parent, B is A parent.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/532939846

https://mafint.atlassian.net/browse/MAF-3875

11. live server error in group fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/532939846

https://mafint.atlassian.net/browse/MAF-3889

12. make save button always loading if no reaction once click p2

In GENERAL LEDGER, OLD PHYSICAL TRADES

once user clicked save button, if no response, make this button always show loading( user can’t click it again until there is response)

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3891

13. MTM update error in DEALS tab fixed. once change to company level for access permission. it should work

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3892

1. PS Ledger and received invoice cannot select contract no once select ccy

• Contract Ccy will be required field

• For each contract, if it has been assigned to PSL/RECEIVE, the CONTRACT CCY in TRADES table is not allowed to be modified. Otherwise, we should allow users to modify CONTRACT CCY.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3878

https://mafint.atlassian.net/browse/MAF-3881

2. Cannot delete paper trades bug fixed

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3879

3. In RECEIVE tab, allocate window, 3rd panel

add TRADE DATE from physical trade

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3883

1. Now, in In PSL, RECEIVE allocate window:

one of the filter conditions is:

un_payment_amt is not 0 (PSL)

un_inv_qty and un_inv_amt is not 0 (receive)

However, after we set the new rule “Amount, below 0.05 will assume as 0 Qty, below 0.0005 will assume as 0”, there would be bugs

For this contract, we should treat it as UN INV QTY = 0, UN INV AMT = 0 and it should not appear in the allocate window 3rd panel.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3874

2. Main contract no missing in ps ledger allocate 2nd panel after clicking 3rd panel row

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3876

1. add combine function in RECEIVE tablein Unassigned tab only (phy_trade_id empty)

only INVOICE rows with same “DATE”，INVOICE PROD，INVOICE SPEC，COMPANY, UNIT，TAX RATE，COUNTERPARTY, INVOICE NO.“ and recalculate the sum of “发票数量，转换后数量，未开票数量，发票金额，未开票金额, 不含税金额，税额“”

Now we have no tax rate （税率）column in table, FE calculate tax rate

tax rate = 税额/不含税金额

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3860

2. Bug in RECEIVE ALLOCATE

RECEIVE ALLOCATE

Initial INV AMT is 1

if I add a new row in 2nd panel whose INV AMT = 1.0001

The INV AMT in 1st panel would be 0.00 but show red

“Amount, below 0.05 will assume as 0”

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3868

3. Add new columns in TRADES tab

1: PRICING PRICE → pricing_price

点价价格

before PRICING DATE

2、CLIENT CONTRACT NO. → counterparty_ref_no

客户合同号

before PURCHASE/SALE

These two are just for record use

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3870

4. Bug for AUTO CO

When I choose contract with different main contract no. (id = 102776, 102775, 102774,102773) and click AUTO CO, auto generated contract no can’t be saved (contract no will disappear after I refresh the page or move to another tab

not an issue. User can update manually to fix this.

Enhancement

https://mafint.atlassian.net/wiki/spaces/MCUGX/pages/2061533185

https://mafint.atlassian.net/browse/MAF-3863